Hi all,
An update on the release and third party related issues. I have created
a branch called "lean-third-party" (link:
https://github.com/apache/incubator-quickstep/tree/lean-third-party).
Some highlights -
1. I removed the source code for many libraries and added patches for
some libraries.
2. There is a shell script that downloads the source code for the third
party libraries and optionally applies patches. No more submodules for
such libraries.
3. Each download link points to a release version of the library. There
are some libraries for which there is no official release version yet,
for such libraries I haven't modified the code and let it as is.
Upgrading the version in the future will require minor modification in
the shell script.
Can I have some volunteers for trying out this branch and ensuring that
the scripts download the libraries and apply the patches correctly? Once
we get green signals from few of the volunteers, I can create a pull
request and update the master branch.
@Zuyu: We don't know what's the right version for protobuf that we need.
Can you please let us know?
Thanks Julian for the inputs on cleaning up the third party library.
On 01/05/2017 01:03 PM, Jignesh Patel wrote:
I think it was Zuyu. Zuyu – can you comment?
Cheers,
Jignesh
On 1/5/17, 12:56 PM, "Harshad Deshmukh" <hars...@cs.wisc.edu> wrote:
If I recall correctly, one of the Quickstep developers wrote the python
script.
On 01/05/2017 11:43 AM, Marc Spehlmann wrote:
> That seems to be the repo with the LLVM code for implementing IWYU. I
think
> what we have in our repo is scripts ontop of that library. I'm wondering
> where the scripts came from.
>
> Thanks,
> Marc
>
> On Thu, Jan 5, 2017 at 10:50 AM, Harshad Deshmukh <hars...@cs.wisc.edu>
> wrote:
>
>> Hi Marc,
>>
>> How about this one for IWYU?
>>
>> https://github.com/include-what-you-use/include-what-you-use
>> /blob/master/LICENSE.TXT
>>
>>
>> On 01/05/2017 10:43 AM, Marc Spehlmann wrote:
>>
>>> I double checked the libraries in thirdy_party. They adhere to Apache's
>>> 3rd
>>> party requirement as they are all apache 2 or opensourced by Google.
The
>>> only issue I saw was that IWYU has no documentation. Anyone know of its
>>> source?
>>>
>>> Library
>>>
>>> Ver
>>>
>>> License
>>>
>>> Notes
>>>
>>> benchmark
>>>
>>> Apache 2.0
>>>
>>> cpplint
>>>
>>> Google
>>>
>>> Header states that reuse is unconditional so long as the copyright
header
>>> stays intact.
>>>
>>> Farmhash
>>>
>>> Google
>>>
>>> No restrictions so long as COPYING file is preserved. See COPYING
>>>
>>> gflags
>>>
>>> Google
>>>
>>> No restrictions so long as COPYING file is preserved. See COPYING
>>>
>>> glog
>>>
>>> Google
>>>
>>> No restrictions so long as COPYING file is preserved. See COPYING
>>>
>>> gtest
>>>
>>> Google
>>>
>>> No restrictions so long as COPYING file is preserved. See COPYING in
>>> subprojects.
>>>
>>> gperftools
>>>
>>> Google
>>>
>>> No restrictions so long as COPYING file is preserved.
>>>
>>> iwyu
>>>
>>>
>>> No license present
>>>
>>> linenoise
>>>
>>> Google
>>>
>>> No restrictions so long as LICENSE file is preserved.
>>>
>>> protobuf
>>>
>>> Google
>>>
>>> No restrictions so long as LICENSE file is preserved.
>>>
>>> RE2
>>>
>>> Google
>>>
>>> No restrictions so long as LICENSE file is preserved.
>>>
>>> tmb
>>>
>>> Apache 2.0
>>>
>>> README: TMB is part of the Quickstep project (copyright Pivotal
Software,
>>> Inc.) and is distributed under the same license terms.
>>>
>>>
>> --
>> Thanks,
>> Harshad
>>
>>
--
Thanks,
Harshad
--
Thanks,
Harshad
