+1 (binding) Downloaded, checked hashes, checked L&N, disclaimer, ran rat.
For next release, please add headers on all .md, .git*, .sh and .patch files. That will reduce the number of rat exceptions. Julian > On Mar 20, 2017, at 9:42 AM, Harshad Deshmukh <hars...@cs.wisc.edu> wrote: > > +1 from me. > > Apart from release metadata: > > Build passes on Ubuntu 14.04 using gcc 4.9.4 > > All tests pass. > > No style issues. > > Thanks Marc for putting together RC7! > > > On 03/20/2017 10:26 AM, Josh Elser wrote: >> +1 >> >> * Verified commits since rc6 >> * sigs/xsums still OK >> >> For your $release.next: >> - gflags still listed in LICENSE unnecessarily (I don't see it bundled) >> >> Thanks for including sha256/512 hashes as well! >> >> - Josh >> >> On 2017-03-19 18:57 (-0400), Marc Spehlmann <spehl.apa...@gmail.com> wrote: >>> This vote is for approval of the Quickstep-0.1.0 RC7. >>> >>> We had a few minor changes since RC6. They were changes to the LICENSE and >>> NOTICE >>> file, as well as updating some headers. These should not have made >>> functional changes. >>> >>> Voters should download, unpack, build, and test the package before voting. >>> >>> A +1 vote means that the package passes all tests and meets Apache >>> guidelines. >>> A -1 vote should be accompanied with a short reason. >>> >>> Votes will remain open for 2 days in light of this being a very similar >>> candidate >>> to the last one. >>> >>> ___ >>> >>> The commit to be voted upon: >>> https://git-wip-us.apache.org/repos/asf?p=incubator-quickstep.git;a=shortlog;h=refs/tags/v0.1.0-rc7 >>> >>> >>> The artifacts to be voted on are located here: >>> https://dist.apache.org/repos/dist/dev/incubator/quickstep/0.1.0/RC7/ >>> >>> Release artifacts are signed with the following key: >>> https://people.apache.org/keys/committer/spehl >>> >>> Please vote on releasing this package as Apache Incubating Quickstep 0.1.0. >>> > > -- > Thanks, > Harshad >
