[ https://issues.apache.org/jira/browse/RANGER-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126682#comment-16126682 ]
Don Bosco Durai commented on RANGER-1732: ----------------------------------------- Good catch. Let me know if you want to fix it? Else, I can fix it. Thanks > Collection added to itself > -------------------------- > > Key: RANGER-1732 > URL: https://issues.apache.org/jira/browse/RANGER-1732 > Project: Ranger > Issue Type: Bug > Components: audit > Reporter: JC > Priority: Trivial > > Hi > In a recent github mirror, I've found suspicious code. > Branch: master > Path: > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java > {code:java} > 32 Collection<AuthzAuditEvent> auditEvents = new ArrayList<>(); > ... > 42 > 43 @Override > 44 public void logAuthzAudits(Collection<AuthzAuditEvent> > auditEvents) { > 45 auditEvents.addAll(auditEvents); > 46 } > {code} > In Line 45, `auditEvents.addAll' should be `this.auditEvents.addAll'? This > might not be an issue but I wanted to report just in case. > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)