----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62918/#review187821 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Oct. 12, 2017, 2:25 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62918/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 2:25 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1829 > https://issues.apache.org/jira/browse/RANGER-1829 > > > Repository: ranger > > > Description > ------- > > When RangerPolicy check the equal for object of > resources/policyItems/denyPolicyItems/allowExceptions/denyExceptions/dataMaskPolicyItems/rowFilterPolicyItems, > it uses the "==" operator. > But it should not use "==", use "equals()" is correctly. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 60daed9 > > > Diff: https://reviews.apache.org/r/62918/diff/1/ > > > Testing > ------- > > tested it! > > > Thanks, > > Qiang Zhang > >