----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62918/#review187854 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java Line 238 (original), 238 (patched) <https://reviews.apache.org/r/62918/#comment264888> I don't think this JIRA is necessary, and if committed, will cause performance degradation. RangerPolicy (and other model objects in Ranger) serve as pure data objects; they are repository of related data and provide getter/setter methods to access/manipulate these data. The '==' is deliberately used here, because only pointer comparison is desired (and not object comparison), just to ensure that data being held and data being supplied is not exactly the same object. There is no need here for deep, object level equality check. This comment applies to all such changes in this patch. Thanks! - Abhay Kulkarni On Oct. 12, 2017, 2:25 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62918/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 2:25 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1829 > https://issues.apache.org/jira/browse/RANGER-1829 > > > Repository: ranger > > > Description > ------- > > When RangerPolicy check the equal for object of > resources/policyItems/denyPolicyItems/allowExceptions/denyExceptions/dataMaskPolicyItems/rowFilterPolicyItems, > it uses the "==" operator. > But it should not use "==", use "equals()" is correctly. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 60daed9 > > > Diff: https://reviews.apache.org/r/62918/diff/1/ > > > Testing > ------- > > tested it! > > > Thanks, > > Qiang Zhang > >
