Please review and fix.
Thanks
Bosco
On 10/26/17, 9:11 AM, "scan-ad...@coverity.com" <scan-ad...@coverity.com> wrote:
Hi,
Please find the latest report on new defect(s) introduced to Apache Ranger
found with Coverity Scan.
1 new defect(s) introduced to Apache Ranger found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 168620: FindBugs: Performance
(FB.SBSC_USE_STRINGBUFFER_CONCATENATION)
/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java:
305 in
org.apache.ranger.services.hdfs.client.HdfsClient.validateConnectionConfigs(java.util.Map)()
________________________________________________________________________________________________________
*** CID 168620: FindBugs: Performance
(FB.SBSC_USE_STRINGBUFFER_CONCATENATION)
/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java:
305 in
org.apache.ranger.services.hdfs.client.HdfsClient.validateConnectionConfigs(java.util.Map)()
299 cluster = "namenode" + (i + 1);
300 configs.put("dfs.namenode.rpc-address."
+ configs.get("dfs.nameservices") + "." + cluster,
301
fsDefaultNameElements[i]);
302 if (i == (fsDefaultNameElements.length
- 1)) {
303 clusters += cluster;
304 } else {
>>> CID 168620: FindBugs: Performance
(FB.SBSC_USE_STRINGBUFFER_CONCATENATION)
>>>
org.apache.ranger.services.hdfs.client.HdfsClient.validateConnectionConfigs(Map)
concatenates strings using + in a loop.
305 clusters += cluster + ",";
306 }
307 }
308 configs.put("dfs.ha.namenodes." +
configs.get("dfs.nameservices"), clusters);
309 }
310 }
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZSbhom32dlDl11LWEm9nX11zsOWMf5dv3Q9Mogo-2FGua3FsLRTFft2V-2FOFC9o0P2e0-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZtwvLNyXEpALHHKXqGKvroU5mWNsNiM7OVRdsl6DJR5LTUChq42fVbU-2Fr1jlwSSZ3yR3k4ycwZTS0QkKayVUGYhpHjV8vMdPHJwfZIZjeDvW59RoGHYuxr3UvsJzGHNk6gAvr6OuaH0vx6ZtLRw-2F0NLST5sMrn2kXHvdALOtTEjnQ-3D-3D
To manage Coverity Scan email notifications for "bo...@apache.org", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4HK0JLY-2BbZ-2FD0yvjg-2BbWSwquqqdEYtbR9nIDW-2BM81kI8TiABM2LsH3tiPfMWf-2FvOsjZSWngS5IRVC-2FH5Pl4zyaK1OE6Dh-2BhR6pXASEFJKZLM-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZtwvLNyXEpALHHKXqGKvroUY-2B5eztdplfpZl4XbRHqpmm-2BR-2BBcRGtjksJzkppkELCz2qJaMgx3MEPa5W36y4ulRSlhcOiAc0lsLanJeQVrTf9E0m-2Bl5ruY29IkebOmDsiu99OFO-2FOGVRupPXUKM1aYuG9NH79Bvn8nEUHlJSJHDDQ-3D-3D
