Coverity issues from couple of weeks back...
Bosco
On 5/24/18, 12:25 PM, "scan-ad...@coverity.com" <scan-ad...@coverity.com>
wrote:
Hi,
Please find the latest report on new defect(s) introduced to Apache Ranger
found with Coverity Scan.
5 new defect(s) introduced to Apache Ranger found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 175683: (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 175683: (FORWARD_NULL)
/security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java:
1043 in
org.apache.ranger.rest.TestXUserREST.test58updateXAuditMapVXResourceNull()()
1037 Mockito.verify(xResourceService).readResource(null);
1038
Mockito.verify(restErrorUtil.createRESTException(Mockito.anyString(),
(MessageEnums)Mockito.any()));
1039 }
1040 @Test
1041 public void test58updateXAuditMapVXResourceNull() {
1042
>>> CID 175683: (FORWARD_NULL)
>>> Passing "null" to "updateXAuditMap", which dereferences it.
1043
Mockito.when(xUserMgr.updateXAuditMap(null)).thenReturn(null);
1044 VXAuditMap
retvXAuditMap=xUserRest.updateXAuditMap(null);
1045 Mockito.verify(xUserMgr).updateXAuditMap(null);
1046 assertNull(retvXAuditMap);
1047
1048 }
/security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java:
1045 in
org.apache.ranger.rest.TestXUserREST.test58updateXAuditMapVXResourceNull()()
1039 }
1040 @Test
1041 public void test58updateXAuditMapVXResourceNull() {
1042
1043
Mockito.when(xUserMgr.updateXAuditMap(null)).thenReturn(null);
1044 VXAuditMap
retvXAuditMap=xUserRest.updateXAuditMap(null);
>>> CID 175683: (FORWARD_NULL)
>>> Passing "null" to "updateXAuditMap", which dereferences it.
1045 Mockito.verify(xUserMgr).updateXAuditMap(null);
1046 assertNull(retvXAuditMap);
1047
1048 }
1049 @Test
1050 public void test59deleteXAuditMap() {
** CID 175682: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 175682: Null pointer dereferences (FORWARD_NULL)
/security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java: 554 in
org.apache.ranger.rest.XUserREST.updateXPermMap(org.apache.ranger.view.VXPermMap)()
548 if (vXPermMap != null) {
549 if
(xResourceService.readResource(vXPermMap.getResourceId()) == null) {
550 throw
restErrorUtil.createRESTException("Invalid Input Data - No resource found with
Id: " + vXPermMap.getResourceId());
551 }
552 }
553
>>> CID 175682: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "vXPermMap" to "updateXPermMap", which
dereferences it.
554 return xUserMgr.updateXPermMap(vXPermMap);
555 }
556
557 @DELETE
558 @Path("/permmaps/{id}")
559 @RangerAnnotationClassName(class_name = VXPermMap.class)
** CID 175681: Incorrect expression (USELESS_CALL)
________________________________________________________________________________________________________
*** CID 175681: Incorrect expression (USELESS_CALL)
/security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java:
550 in
org.apache.ranger.service.TestRangerServiceDefService.test4getAllServiceDefs()()
544 Assert.assertNotNull(dbRangerServiceDef);
545 Mockito.verify(daoManager).getXXResourceDef();
546 Mockito.verify(daoManager).getXXAccessTypeDef();
547 Mockito.verify(daoManager).getXXPolicyConditionDef();
548 Mockito.verify(daoManager).getXXContextEnricherDef();
549 Mockito.verify(daoManager).getXXEnumDef();
>>> Calling
"(org.apache.ranger.db.RangerDaoManager)org.mockito.Mockito.verify(daoManager).getXXEnumElementDef()"
is only useful for its return value, which is ignored.
550 Mockito.verify(daoManager).getXXEnumElementDef();
551 }
552
553 @Test
554 public void test5getPopulatedViewObject() {
555 XXPortalUserDao xPortalUserDao =
Mockito.mock(XXPortalUserDao.class);
** CID 175680: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 175680: Null pointer dereferences (FORWARD_NULL)
/security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java:
838 in org.apache.ranger.rest.TestXUserREST.test45updateXPermMap()()
832
833 Mockito.verify(xUserMgr).updateXPermMap(permMap);
834
Mockito.verify(xResourceService).readResource(permMap.getResourceId());
835 }
836 @Test
837 public void test45updateXPermMap() {
>>> CID 175680: Null pointer dereferences (FORWARD_NULL)
>>> Passing "null" to "updateXPermMap", which dereferences it.
838
Mockito.when(xUserMgr.updateXPermMap(null)).thenReturn(null);
839 VXPermMap retVxGroup=xUserRest.updateXPermMap(null);
840 assertNull(retVxGroup);
841 Mockito.verify(xUserMgr).updateXPermMap(null);
842 }
843 @Test
** CID 175679: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 175679: Null pointer dereferences (FORWARD_NULL)
/security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java: 638 in
org.apache.ranger.rest.XUserREST.updateXAuditMap(org.apache.ranger.view.VXAuditMap)()
632 if (vXAuditMap != null) {
633 if
(xResourceService.readResource(vXAuditMap.getResourceId()) == null) {
634 throw
restErrorUtil.createRESTException("Invalid Input Data - No resource found with
Id: " + vXAuditMap.getResourceId(), MessageEnums.INVALID_INPUT_DATA);
635 }
636 }
637
>>> CID 175679: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "vXAuditMap" to "updateXAuditMap", which
dereferences it.
638 return xUserMgr.updateXAuditMap(vXAuditMap);
639 }
640
641 @DELETE
642 @Path("/auditmaps/{id}")
643 @RangerAnnotationClassName(class_name = VXAuditMap.class)
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZSbhom32dlDl11LWEm9nX11zsOWMf5dv3Q9Mogo-2FGua3FsLRTFft2V-2FOFC9o0P2e0-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZs9GjIYzXgfcpf08hs269Aqb0Nmv-2F74IftjmdsLkLyC3L2HyOLN4Qx4H-2FZzfs83JHRfVmBC-2BOAzSO9dWAcNbVHV5u9hZZ8bXiCGuA1fJgk88afMUPTr7mkdS1ZAUJprprXYU-2BGRowPpAQmG9p0LgimenY4qdm9XJQ2JTqp3UtoC8A-3D-3D
To manage Coverity Scan email notifications for "bo...@apache.org", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4HK0JLY-2BbZ-2FD0yvjg-2BbWSwquqqdEYtbR9nIDW-2BM81kI8TiABM2LsH3tiPfMWf-2FvOsjZSWngS5IRVC-2FH5Pl4zyaK1OE6Dh-2BhR6pXASEFJKZLM-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZs9GjIYzXgfcpf08hs269AqyAdaXEtpCQAP0fGpn60SBjm0ypyVzIvAKeFeuhfHWpohF-2F8bFLH9YZGQf7WIWdsQaGJVyTLM1NlDfktYb8dyAYQjp-2BqzWCKYjrvvdkCpqTTqSuPhMrAOgVzNFWu6T0eo0H5DRLNzJd-2Bbl5hpJcgt4Q-3D-3D
