> On March 7, 2018, 11:31 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > > Line 384 (original), 384 (patched) > > <https://reviews.apache.org/r/65950/diff/1/?file=1972226#file1972226line384> > > > > Please consider adding another method with a diffrent signature to get > > list of RangerPolicyItemEvaluators, instead of changing signature and > > implementation of this critical method. > > > > Signature of new method may look like: > > > > List<RangerPolicyItemEvaluator> getDeterminingPolicyItems(String user, > > Set<String> userGroups, List<String> accessType); > > > > Then have the caller provide list of all available hbase accessTypes - > > they can be figured out from hbase Service-definition). > > > > Method implementation may call getDeterminingPolicyItem for each > > accessType to build a list. > > > > This will isolate current implementation from hbase specific changes. > > > > Thanks!
Now using getResourceAcls API from RANGER-2061. - Ankit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65950/#review198831 ----------------------------------------------------------- On Aug. 20, 2018, 6:14 p.m., Ankit Singhal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65950/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2018, 6:14 p.m.) > > > Review request for ranger and Ramesh Mani. > > > Bugs: RANGER-1958 > https://issues.apache.org/jira/browse/RANGER-1958 > > > Repository: ranger > > > Description > ------- > > RANGER-1958 [HBase] Implement getUserPermissions API of > AccessControlService.Interface to allow clients to access HBase permissions > stored in Ranger > > > Diffs > ----- > > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java > cdaad00a4 > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java > d85339a09 > > hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java > 38408855d > hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea > > > Diff: https://reviews.apache.org/r/65950/diff/2/ > > > Testing > ------- > > Unit testing is done > > > Thanks, > > Ankit Singhal > >