----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65950/#review209155 -----------------------------------------------------------
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java Lines 36 (patched) <https://reviews.apache.org/r/65950/#comment293449> Could you please fix PMD violations? ``` [INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-hbase-plugin --- [INFO] PMD Failure: org/apache/ranger/authorization/hbase/AuthorizationSession.java:36 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.plugin.policyengine.RangerResourceACLs'. [INFO] PMD Failure: org.apache.ranger.authorization.hbase.HBaseRangerAuthorizationTest:1007 Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 'userPermission'.. ``` hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java Lines 1007 (patched) <https://reviews.apache.org/r/65950/#comment293450> Please fix PMD violation. ``` [INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-hbase-plugin --- [INFO] PMD Failure: org/apache/ranger/authorization/hbase/AuthorizationSession.java:36 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.plugin.policyengine.RangerResourceACLs'. [INFO] PMD Failure: org.apache.ranger.authorization.hbase.HBaseRangerAuthorizationTest:1007 Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 'userPermission'.. ``` - Velmurugan Periasamy On Sept. 26, 2018, 10:40 p.m., Ankit Singhal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65950/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2018, 10:40 p.m.) > > > Review request for ranger and Ramesh Mani. > > > Bugs: RANGER-1958 > https://issues.apache.org/jira/browse/RANGER-1958 > > > Repository: ranger > > > Description > ------- > > RANGER-1958 [HBase] Implement getUserPermissions API of > AccessControlService.Interface to allow clients to access HBase permissions > stored in Ranger > > > Diffs > ----- > > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java > cdaad00a4 > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java > d85339a09 > > hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java > 38408855d > hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea > > > Diff: https://reviews.apache.org/r/65950/diff/3/ > > > Testing > ------- > > Unit testing is done > > > Thanks, > > Ankit Singhal > >