----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69209/#review210167 -----------------------------------------------------------
Ship it! Tested patch for given use case and its working. - Pradeep Agrawal On Oct. 29, 2018, 11:43 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69209/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2018, 11:43 p.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, and > Velmurugan Periasamy. > > > Bugs: RANGER-2272 > https://issues.apache.org/jira/browse/RANGER-2272 > > > Repository: ranger > > > Description > ------- > > Access type names and resources definition names in Ranger service definition > are required to be in lowercase. Ranger Policy also ensure that access type > names and resource-definition names are in lowercase when it is persisted in > the database. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java > 9de860d42 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java > c7062ddda > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java > 140a9edf5 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java > 5bdffda92 > > > Diff: https://reviews.apache.org/r/69209/diff/1/ > > > Testing > ------- > > Tested with mysql and postgres database back-ends. Created policy containing > uppercase access-type name (such as 'Read' for hive policy), and uppercase > resource-def name (such as 'DATABASE' for hive-policy). Ensured that the > created policy can be retrieved using GUI. Verified that database contained > correct, lowercase access-type name ('read') and resource-def name > ('database') > > > Thanks, > > Abhay Kulkarni > >
