-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69209/
-----------------------------------------------------------

(Updated Oct. 30, 2018, 7 p.m.)


Review request for ranger, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, and 
Velmurugan Periasamy.


Summary (updated)
-----------------

RANGER-2272: Ensure that case of resource-definition names and access-type 
names in Ranger policy is the same as in service-definition after successful 
validation


Bugs: RANGER-2272
    https://issues.apache.org/jira/browse/RANGER-2272


Repository: ranger


Description (updated)
-------

Ranger Policy validation needs to ensure that access type names and 
resource-definition names specified in the Ranger policy are in the same case 
as specified in service-definition before the policy is persisted in the 
database.


Diffs (updated)
-----

  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
 9de860d42 
  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java
 6a1b3e111 
  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
 c7062ddda 
  
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java
 140a9edf5 
  
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java
 5bdffda92 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
9ee5faeb3 


Diff: https://reviews.apache.org/r/69209/diff/2/

Changes: https://reviews.apache.org/r/69209/diff/1-2/


Testing
-------

Tested with mysql and postgres database back-ends. Created policy containing 
uppercase access-type name (such as 'Read' for hive policy), and uppercase 
resource-def name (such as 'DATABASE' for hive-policy). Ensured that the 
created policy can be retrieved using GUI. Verified that database contained 
correct, lowercase access-type name ('read') and resource-def name ('database')


Thanks,

Abhay Kulkarni

Reply via email to