-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70052/#review213191
-----------------------------------------------------------




agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java
Line 137 (original), 140 (patched)
<https://reviews.apache.org/r/70052/#comment299058>

    Will it be better to not change existing API, but introduce another one? 
The old API implementation will call new API with policyVersion as null. This 
will have a better chance of not breaking plugin code written for old API. 
Please review.



agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
Line 576 (original), 576 (patched)
<https://reviews.apache.org/r/70052/#comment299059>

    There is no change from the previous version (except whitespaces). Please 
consider reverting it.



security-admin/contrib/solr_for_audit_setup/conf/managed-schema
Lines 94 (patched)
<https://reviews.apache.org/r/70052/#comment299057>

    Should the type be "long"? Please review.


- Abhay Kulkarni


On Feb. 25, 2019, 7:11 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70052/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2019, 7:11 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja 
> Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2340
>     https://issues.apache.org/jira/browse/RANGER-2340
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2340:Add Policy Version to the Ranger Audit log
> 
> 
> Diffs
> -----
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
>  7b806e7 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java 
> be22df7 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java
>  8d97e99 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java
>  c4e7b75 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
>  b29f152 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
>  289ec9b 
>   
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
>  466f22a 
>   security-admin/contrib/solr_for_audit_setup/conf/managed-schema 2cfd617 
>   
> security-admin/db/mysql/patches/038-add-column-version-in-x_policy_export_audit.sql
>  PRE-CREATION 
>   
> security-admin/db/oracle/patches/038-add-column-version-in-x_policy_export_audit.sql
>  PRE-CREATION 
>   
> security-admin/db/postgres/patches/038-add-column-version-in-x_policy_export_audit.sql
>  PRE-CREATION 
>   
> security-admin/db/sqlanywhere/patches/038-add-column-version-in-x_policy_export_audit.sql
>  PRE-CREATION 
>   
> security-admin/db/sqlserver/patches/038-add-column-version-in-x_policy_export_audit.sql
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/entity/XXPolicyExportAudit.java
>  4060e01 
>   
> security-admin/src/main/java/org/apache/ranger/service/XPolicyExportAuditServiceBase.java
>  51711a8 
>   
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
>  1b49c13 
>   security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 
> 1fe85ae 
>   
> security-admin/src/main/java/org/apache/ranger/view/VXPolicyExportAudit.java 
> 8fca5ba 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> cce9358 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 0b47ba7 
> 
> 
> Diff: https://reviews.apache.org/r/70052/diff/1/
> 
> 
> Testing
> -------
> 
> Tested in Local VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Reply via email to