----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70052/ -----------------------------------------------------------
(Updated March 6, 2019, 4:13 a.m.) Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Changes ------- Address review comments. Bugs: RANGER-2340 https://issues.apache.org/jira/browse/RANGER-2340 Repository: ranger Description ------- RANGER-2340:Add Policy Version to the Ranger Audit log Diffs (updated) ----- agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7b806e7 agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java be22df7 agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 8d97e99 agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java c4e7b75 agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java b29f152 hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 466f22a hive-agent/pom.xml 53f6e2f security-admin/contrib/solr_for_audit_setup/conf/managed-schema 2cfd617 security-admin/db/mysql/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION security-admin/db/oracle/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION security-admin/db/postgres/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION security-admin/db/sqlanywhere/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION security-admin/db/sqlserver/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION security-admin/src/main/java/org/apache/ranger/entity/XXPolicyExportAudit.java 4060e01 security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java a43d076 security-admin/src/main/java/org/apache/ranger/service/XPolicyExportAuditServiceBase.java 51711a8 security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 1b49c13 security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 1fe85ae security-admin/src/main/java/org/apache/ranger/view/VXPolicyExportAudit.java 8fca5ba security-admin/src/main/webapp/scripts/models/RangerPolicy.js 4027132 security-admin/src/main/webapp/scripts/modules/globalize/message/en.js cce9358 security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js da0078f security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js f20b2e8 security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 26b43f7 security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java ef4865a Diff: https://reviews.apache.org/r/70052/diff/2/ Changes: https://reviews.apache.org/r/70052/diff/1-2/ Testing (updated) ------- Tested in Local VM - Added Policy Version to UI - Added Policy Version to UI / pop up window when policy details are selected. - Fixed a test failure. - Upgrade path to address the solr schema would be manual which will be documented. Thanks, Ramesh Mani