----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70981/#review216255 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java Lines 72 (patched) <https://reviews.apache.org/r/70981/#comment303384> Seems confusing. What if resourceTags is null? Do we allow or not? According to this, if it is null we don't allow, but if empty we will allow. I might be wrong. - Don Bosco Durai On July 1, 2019, 1:03 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70981/ > ----------------------------------------------------------- > > (Updated July 1, 2019, 1:03 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, > and Velmurugan Periasamy. > > > Bugs: RANGER-2494 > https://issues.apache.org/jira/browse/RANGER-2494 > > > Repository: ranger > > > Description > ------- > > RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsAnyPresentConditionEvaluator.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70981/diff/1/ > > > Testing > ------- > > Testing done in LOCAL VM > > > Thanks, > > Ramesh Mani > >
