----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70981/#review216319 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAnyOfExpectedTagsPresentConditionEvaluator.java Lines 64 (patched) <https://reviews.apache.org/r/70981/#comment303490> Please review if this needs to be initialized to "false". agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAnyOfExpectedTagsPresentConditionEvaluator.java Lines 66 (patched) <https://reviews.apache.org/r/70981/#comment303491> Is this check necessary? agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerNoneOfExpectedTagsPresentConditionEvaluator.java Lines 66 (patched) <https://reviews.apache.org/r/70981/#comment303489> Is this check necessary? - Abhay Kulkarni On July 2, 2019, 12:07 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70981/ > ----------------------------------------------------------- > > (Updated July 2, 2019, 12:07 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, > and Velmurugan Periasamy. > > > Bugs: RANGER-2494 > https://issues.apache.org/jira/browse/RANGER-2494 > > > Repository: ranger > > > Description > ------- > > RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAnyOfExpectedTagsPresentConditionEvaluator.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerNoneOfExpectedTagsPresentConditionEvaluator.java > PRE-CREATION > > agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerCustomConditionMatcherTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70981/diff/6/ > > > Testing > ------- > > Testing done in LOCAL VM > > > Thanks, > > Ramesh Mani > >
