----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71484/#review217747 -----------------------------------------------------------
ranger-solr-plugin-shim/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java Lines 43 (patched) <https://reviews.apache.org/r/71484/#comment305112> Is 'impl' needed as instance member? Looks like this is used only in init0(); if yes, consider moving this as a local variable in init0(). security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java Lines 237 (patched) <https://reviews.apache.org/r/71484/#comment305110> " ," => "," // remove space security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java Lines 239 (patched) <https://reviews.apache.org/r/71484/#comment305111> Consider updates to handle leading/trialing spaces: String[] allRolesServiceTypes = StringUtils.split(serviceTypesToGetAllRoles, ","); if (allRolesServiceTypes != null) { for (String allRolesServiceType : allRolesServiceTypes) { if (StringUtils.equalsIgnoreCase(serviceTypeName, StringUtils.trim(allRolesServiceType))) { getAllRoles = true; break; } } } security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java Lines 262 (patched) <https://reviews.apache.org/r/71484/#comment305109> Consider adding following method to return serviceType from serviceId (similar to an existing method in this class that returns serviceType from serviceName): class XXServiceDefDao .. { ... public String findServiceDefTypeByServiceId(Long serviceId) { ... } } - Madhan Neethiraj On Sept. 13, 2019, 11:06 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71484/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2019, 11:06 p.m.) > > > Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2393 > https://issues.apache.org/jira/browse/RANGER-2393 > > > Repository: ranger > > > Description > ------- > > Implemented Document level authorization support for Solr based on user roles. > > > Diffs > ----- > > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > 48d4fb74c > > ranger-solr-plugin-shim/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > 4cfa7e188 > security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java > 28b2c1108 > > > Diff: https://reviews.apache.org/r/71484/diff/1/ > > > Testing > ------- > > 1. Patched cluster with the changes and verified basic functionality is > working fine. > 2. Also verified few negative cases on authorization to solr. > > > Thanks, > > Sailaja Polavarapu > >
