----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71484/#review217761 -----------------------------------------------------------
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java Lines 495 (patched) <https://reviews.apache.org/r/71484/#comment305135> Please consider rewritting this to return a single return in the method. String ret = null; if (roles != null && !roles.isEmpty()) { StringBuilder builder = new StringBuilder(); for (String role : roles) { addDisjunctiveRawClause(builder, role); } if (allRolesToken != null && !allRolesToken.isEmpty()) { addDisjunctiveRawClause(builder, allRolesToken); } ret = builder.toString(); } } return ret; } plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java Lines 572 (patched) <https://reviews.apache.org/r/71484/#comment305134> remove this comment. ranger-solr-plugin-shim/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java Lines 121 (patched) <https://reviews.apache.org/r/71484/#comment305133> Please print the "args" also for debug log - Ramesh Mani On Sept. 13, 2019, 11:06 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71484/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2019, 11:06 p.m.) > > > Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2393 > https://issues.apache.org/jira/browse/RANGER-2393 > > > Repository: ranger > > > Description > ------- > > Implemented Document level authorization support for Solr based on user roles. > > > Diffs > ----- > > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > 48d4fb74c > > ranger-solr-plugin-shim/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > 4cfa7e188 > security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java > 28b2c1108 > > > Diff: https://reviews.apache.org/r/71484/diff/1/ > > > Testing > ------- > > 1. Patched cluster with the changes and verified basic functionality is > working fine. > 2. Also verified few negative cases on authorization to solr. > > > Thanks, > > Sailaja Polavarapu > >
