----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71993/#review219347 -----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java Lines 110 (patched) <https://reviews.apache.org/r/71993/#comment307488> Please consider inserting the unit (milliseconds) in the property name here and in usersync property name. tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java Lines 45 (patched) <https://reviews.apache.org/r/71993/#comment307491> Please consider removing this check if the thread is not started at all when metrics collection is disabled. tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java Lines 141 (patched) <https://reviews.apache.org/r/71993/#comment307490> If the metrics collection is disabled, is there any reason to create TagSyncMetricsProducer object and run it in the thread? tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java Lines 143 (patched) <https://reviews.apache.org/r/71993/#comment307489> Please ensure that the thread is a damon thread. Please see TagAdminRESTSink.start() for reference. - Abhay Kulkarni On Jan. 21, 2020, 7:14 a.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71993/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2020, 7:14 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and > Pradeep Agrawal. > > > Bugs: RANGER-2699 > https://issues.apache.org/jira/browse/RANGER-2699 > > > Repository: ranger > > > Description > ------- > > Added metrics information in usersync and tagsync services > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java > PRE-CREATION > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java > 6d27b02cd > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java > PRE-CREATION > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java > 8806c7469 > tagsync/src/main/resources/ranger-tagsync-site.xml 9a14c1cc7 > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > 1d4e37fcf > > ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java > PRE-CREATION > ugsync/src/test/resources/ranger-ugsync-site.xml 0a1a86da0 > > unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java > 1ee5e21ba > > > Diff: https://reviews.apache.org/r/71993/diff/5/ > > > Testing > ------- > > Validated metrics which are getting generated at configured interval when > usersync and tagsync services start. > I have kept below parameter configurable > 1. Metrics Name (Default value metrics.json) > 2. Metrics Directory (must have write permission and default value /tmp/) > 3. frequency at metrics get updated (default value: 10 sec) > 4. metrics enabled or disabled > Checked for metrics.json being regularly updated based on JVM resources > utilization. Validated for usersync as well as tagsync process. > > > Thanks, > > Dineshkumar Yadav > >
