----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71993/#review219381 -----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java Lines 33 (patched) <https://reviews.apache.org/r/71993/#comment307553> any specific reason for not calling start() method here using run() ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java Lines 246 (patched) <https://reviews.apache.org/r/71993/#comment307552> Can you change default name of different modules. it can be ranger_usersync_metric.json here. - Pradeep Agrawal On Jan. 27, 2020, 10:46 a.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71993/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2020, 10:46 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and > Pradeep Agrawal. > > > Bugs: RANGER-2699 > https://issues.apache.org/jira/browse/RANGER-2699 > > > Repository: ranger > > > Description > ------- > > Added metrics information in usersync and tagsync services > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java > PRE-CREATION > tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510 > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java > c4173da68 > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java > PRE-CREATION > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java > 8806c7469 > tagsync/src/main/resources/ranger-tagsync-default.xml 1034bc6e5 > tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492 > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > a041345cf > > ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java > PRE-CREATION > unixauthservice/conf.dist/ranger-ugsync-default.xml 0f88aa3f3 > unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b > > unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java > 1ee5e21ba > > > Diff: https://reviews.apache.org/r/71993/diff/9/ > > > Testing > ------- > > Validated metrics which are getting generated at configured interval when > usersync and tagsync services start. > I have kept below parameter configurable > 1. Metrics Name (Default value metrics.json) > 2. Metrics Directory (must have write permission and default value /tmp/) > 3. frequency at metrics get updated (default value: 10 sec) > 4. metrics enabled or disabled > Checked for metrics.json being regularly updated based on JVM resources > utilization. Validated for usersync as well as tagsync process. > > > Thanks, > > Dineshkumar Yadav > >
