----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71993/#review219535 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On Feb. 5, 2020, 2:49 p.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71993/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2020, 2:49 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and > Pradeep Agrawal. > > > Bugs: RANGER-2699 > https://issues.apache.org/jira/browse/RANGER-2699 > > > Repository: ranger > > > Description > ------- > > Added metrics information in usersync and tagsync services > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java > PRE-CREATION > tagsync/conf/templates/installprop2xml.properties 510cd6f44 > tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510 > tagsync/scripts/install.properties be33cc274 > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java > c4173da68 > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java > PRE-CREATION > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java > 8806c7469 > tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492 > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > a041345cf > > ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java > PRE-CREATION > unixauthservice/scripts/install.properties d4c651308 > unixauthservice/scripts/templates/installprop2xml.properties fa342fbff > unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b > > unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java > 1ee5e21ba > > > Diff: https://reviews.apache.org/r/71993/diff/11/ > > > Testing > ------- > > Validated metrics which are getting generated at configured interval when > usersync and tagsync services start. > I have kept below parameter configurable > 1. Metrics Name (Default value ranger_tagsync_metric.json and > ranger_usersync_metric.json) > 2. Metrics Directory (must have write permission and default value is logdir) > 3. frequency at metrics get updated (default value: 10 sec) > 4. metrics enabled or disabled (default is disabled) > Checked for ranger_tagsync_metric.json and ranger_usersync_metric.json being > regularly updated based on JVM resources utilization. Validated for usersync > as well as tagsync process. > > > Thanks, > > Dineshkumar Yadav > >