> On June 15, 2021, 9:59 p.m., Ramesh Mani wrote: > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java > > Line 44 (original), 44 (patched) > > <https://reviews.apache.org/r/73424/diff/1/?file=2250920#file2250920line44> > > > > Error message need not to have "==>". Symbol "==>/<==" is to show in > > debug log entry/exit of the routine. please consider correcting it all off > > this occurance.
Hmm... Isn't this a debug log for entering `connectionTest`? A routine doesn't mean a method? I'm confused... > On June 15, 2021, 9:59 p.m., Ramesh Mani wrote: > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java > > Line 109 (original), 109 (patched) > > <https://reviews.apache.org/r/73424/diff/1/?file=2250920#file2250920line109> > > > > <== instead of ==> Also, this looks entering a branch. Why should `<==` (= exit) be used here? Exit from what? Looks like there are many inconsistent logging even in Presto plugin. Could you give more explanation about logging regulation so that I can fix all logging in Presto plugin in this review request. - Naoki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73424/#review223153 ----------------------------------------------------------- On June 15, 2021, 9:46 p.m., Naoki Takezoe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73424/ > ----------------------------------------------------------- > > (Updated June 15, 2021, 9:46 p.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > Would make logging in Presto plugin more consistent. > > > Diffs > ----- > > > plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java > d95876a7d > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java > 7b55b77bd > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java > 008bf0fa6 > > > Diff: https://reviews.apache.org/r/73424/diff/1/ > > > Testing > ------- > > > Thanks, > > Naoki Takezoe > >
