> On June 15, 2021, 9:59 p.m., Ramesh Mani wrote: > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java > > Line 109 (original), 109 (patched) > > <https://reviews.apache.org/r/73424/diff/1/?file=2250920#file2250920line109> > > > > <== instead of ==> > > Naoki Takezoe wrote: > Also, this looks entering a branch. Why should `<==` (= exit) be used > here? Exit from what? > > Looks like there are many inconsistent logging even in Presto plugin. > Could you give more explanation about logging regulation so that I can fix > all logging in Presto plugin in this review request. > > Naoki Takezoe wrote: > For example, some methods have multiple `==>` in a single method. Some > methods have `<==` with error level not debug level. It would be impossible > to correct all ocureences without having solid regulation. I just aim to > correct wrong wordings in Presto plugin for searchability of logs in this > review request. > > Ramesh Mani wrote: > ok then, I see that presto plugin have inconsistent usage of "==>". We > can omit that change for this patch and can be corrected later.
Thank you! - Naoki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73424/#review223153 ----------------------------------------------------------- On June 16, 2021, 6:09 a.m., Naoki Takezoe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73424/ > ----------------------------------------------------------- > > (Updated June 16, 2021, 6:09 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > Would make logging in Presto plugin more consistent. > > > Diffs > ----- > > > plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java > d95876a7d > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java > 7b55b77bd > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java > 008bf0fa6 > > > Diff: https://reviews.apache.org/r/73424/diff/2/ > > > Testing > ------- > > > Thanks, > > Naoki Takezoe > >
