> On April 7, 2022, 10:14 p.m., Ramesh Mani wrote: > > security-admin/scripts/change_password_util.py > > Lines 1 (patched) > > <https://reviews.apache.org/r/73937/diff/1/?file=2267234#file2267234line1> > > > > Deleting file changepasswordutil.py and creating with a new file name > > change_password_util.py may result in failure of the file not to be > > included in package or it may be reference in other scripts which has to be > > changed. Please refer all those reference and correct it or best to use the > > same name. > > Kirby Zhou wrote: > I suggest that this commit DO NOT change any filename, open a new review > to change filename. > > Kirby Zhou wrote: > This patch too heavy, may split it into 3 step? > > > 1. migrate to python3 > 2. rename of identifier such as "propertyName -> property_name" > 3. rename of file and related files.
I understand, the changes will require thorough testing. Following PEP 8 guidelines, it is best we have the snake case for file names, method names and variable names. As suggested earlier I'll split the patch into multiple parts. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73937/#review224265 ----------------------------------------------------------- On April 7, 2022, 7:11 p.m., Abhishek Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73937/ > ----------------------------------------------------------- > > (Updated April 7, 2022, 7:11 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3697 > https://issues.apache.org/jira/browse/RANGER-3697 > > > Repository: ranger > > > Description > ------- > > Python 2 has sunset as of Jan 1, 2020. All scripts using python2 should > eventually move to python3. > > Initial Review - will be updated to include all scripts. > > Changes include: > 1. Support only for Python3 and above. > 2. Conformity with PEP 8 guidelines. > 3. Code optimizations and performance improvements. > > > Diffs > ----- > > agents-common/scripts/upgrade-plugin.py d865ee366 > agents-common/scripts/upgrade_plugin.py PRE-CREATION > ranger-util/src/scripts/saveVersion.py 51227542d > ranger-util/src/scripts/save_version.py PRE-CREATION > security-admin/scripts/change_password_util.py PRE-CREATION > security-admin/scripts/change_username_util.py PRE-CREATION > security-admin/scripts/changepasswordutil.py e45dab643 > security-admin/scripts/changeusernameutil.py 699f945f0 > security-admin/scripts/deleteUserGroupUtil.py 1c9f58385 > security-admin/scripts/delete_user_group_util.py PRE-CREATION > security-admin/scripts/ranger_credential_helper.py 85f29ac43 > security-admin/scripts/restrict_permissions.py b19bafe9b > security-admin/scripts/role_based_user_search_util.py PRE-CREATION > security-admin/scripts/rolebasedusersearchutil.py 612db33df > security-admin/scripts/updateUserAndGroupNamesInJson.py c40ec4406 > security-admin/scripts/upgrade_admin.py 85f57b8ce > security-admin/src/bin/ranger_install.py 39b9d1f81 > security-admin/src/bin/ranger_usersync.py 4374896c7 > security-admin/src/bin/service_start.py ea13b85af > > > Diff: https://reviews.apache.org/r/73937/diff/1/ > > > Testing > ------- > > Pending. > > > Thanks, > > Abhishek Kumar > >
