> On April 8, 2022, 2:12 p.m., Pradeep Agrawal wrote: > > Currently python2 and python3 both are supported, why we want to remove > > python2 support ? Also What issues are you getting when you execute all > > these script in python3 ? > > Abhishek Kumar wrote: > Article explaining the need to remove python2: > https://www.python.org/doc/sunset-python-2/#:~:text=We%20have%20decided%20that%20January,as%20soon%20as%20you%20can. > Testing is pending. > > Pradeep Agrawal wrote: > is current script not running in python 3 ? if not please , then please > let me know only those lines and I shall fix that. Refer : > https://issues.apache.org/jira/browse/RANGER-2759 , we need to support both, > however default can be set to python3. > > Kirby Zhou wrote: > At least files in ./migration-util/ remains old-style code. > > > ./migration-util/ambari2.1-hdp2.3-ranger0.50/bin/import_ranger_to_ambari.py > > ``` > 845 except Exception, e: > 846 print "Error loading ranger-admin properties from xml > files : ", str(e) > > ``` > > Just remove it or ignore?
These files are not being used by ranger, it was for the ambari integration (not being used since long), i dont think ambari is supporting python 3 now. However if required, we can fix it in such a way that it can work in both (python 2 and python 3). - Pradeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73937/#review224282 ----------------------------------------------------------- On April 7, 2022, 7:11 p.m., Abhishek Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73937/ > ----------------------------------------------------------- > > (Updated April 7, 2022, 7:11 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3697 > https://issues.apache.org/jira/browse/RANGER-3697 > > > Repository: ranger > > > Description > ------- > > Python 2 has sunset as of Jan 1, 2020. All scripts using python2 should > eventually move to python3. > > Initial Review - will be updated to include all scripts. > > Changes include: > 1. Support only for Python3 and above. > 2. Conformity with PEP 8 guidelines. > 3. Code optimizations and performance improvements. > > > Diffs > ----- > > agents-common/scripts/upgrade-plugin.py d865ee366 > agents-common/scripts/upgrade_plugin.py PRE-CREATION > ranger-util/src/scripts/saveVersion.py 51227542d > ranger-util/src/scripts/save_version.py PRE-CREATION > security-admin/scripts/change_password_util.py PRE-CREATION > security-admin/scripts/change_username_util.py PRE-CREATION > security-admin/scripts/changepasswordutil.py e45dab643 > security-admin/scripts/changeusernameutil.py 699f945f0 > security-admin/scripts/deleteUserGroupUtil.py 1c9f58385 > security-admin/scripts/delete_user_group_util.py PRE-CREATION > security-admin/scripts/ranger_credential_helper.py 85f29ac43 > security-admin/scripts/restrict_permissions.py b19bafe9b > security-admin/scripts/role_based_user_search_util.py PRE-CREATION > security-admin/scripts/rolebasedusersearchutil.py 612db33df > security-admin/scripts/updateUserAndGroupNamesInJson.py c40ec4406 > security-admin/scripts/upgrade_admin.py 85f57b8ce > security-admin/src/bin/ranger_install.py 39b9d1f81 > security-admin/src/bin/ranger_usersync.py 4374896c7 > security-admin/src/bin/service_start.py ea13b85af > > > Diff: https://reviews.apache.org/r/73937/diff/1/ > > > Testing > ------- > > Pending. > > > Thanks, > > Abhishek Kumar > >
