----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74611/#review225801 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java Lines 674 (patched) <https://reviews.apache.org/r/74611/#comment314231> Is parameter datasetId necessary, given each object dataSharesInDataset also has datasetId? security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java Lines 681 (patched) <https://reviews.apache.org/r/74611/#comment314230> The call should either succeed in saving all objects or fail without saving any. Use of one transaction for each object here violates this. Please review and update. security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java Lines 731 (patched) <https://reviews.apache.org/r/74611/#comment314232> - ensureRequestsDoNotExist() => validate() - This will be a good place to enfoce ACL specified in Dataset and DataShare - consider adding validation that dataSharesInDataset doesn't contain duplicate entries (datasetId + dataShareId combination) security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java Lines 834 (patched) <https://reviews.apache.org/r/74611/#comment314233> Consider adding validation that each entry in dataSharesInDataset has datasetId specified in the parameter datasetId. - Madhan Neethiraj On Sept. 25, 2023, 4:21 a.m., Subhrat Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74611/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2023, 4:21 a.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, and Prashant Satam. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4415 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4415 > > > Repository: ranger > > > Description > ------- > > In Dataset details page - Add datashare - user can select multiple datasets > and send request to dataset owner. We need a new POST API that can accept > request for multiple datashares. > Added API /dataset/{id}/datashare to accept List<RangerDataShareInDataset> > and return List<RangerDataShareInDataset>. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > ff6b2b23e > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 653e397d4 > > security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java > de9014072 > > > Diff: https://reviews.apache.org/r/74611/diff/2/ > > > Testing > ------- > > Validated: > 1. Addition of multiple datashares in POST API. > 2. Tried to add duplicate request (same datashare and dataset ID), 400 is > thrown. > 3. Tried to add an existing request, with request for 2 new datashares in a > dataset. API failed for all the requests. > > > Thanks, > > Subhrat Chaudhary > >
