> On Sept. 30, 2023, 1:51 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Lines 674 (patched) > > <https://reviews.apache.org/r/74611/diff/2/?file=2279986#file2279986line674> > > > > Is parameter datasetId necessary, given each object dataSharesInDataset > > also has datasetId?
We have existing POST API /dataset/datashare (fr single DataSharedInDataset), this is to support multiple requests. > On Sept. 30, 2023, 1:51 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Lines 681 (patched) > > <https://reviews.apache.org/r/74611/diff/2/?file=2279986#file2279986line681> > > > > The call should either succeed in saving all objects or fail without > > saving any. Use of one transaction for each object here violates this. > > Please review and update. Transaction is removed. > On Sept. 30, 2023, 1:51 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Lines 731 (patched) > > <https://reviews.apache.org/r/74611/diff/2/?file=2279986#file2279986line736> > > > > - ensureRequestsDoNotExist() => validate() > > - This will be a good place to enfoce ACL specified in Dataset and > > DataShare > > - consider adding validation that dataSharesInDataset doesn't contain > > duplicate entries (datasetId + dataShareId combination) 1. Updated ensureRequestsDoNotExist() => validate() 2. Implementation of ACL enforcement for requests is tracked in https://issues.apache.org/jira/browse/RANGER-4443 3. Validation to avoid duplicate entries for datasetId + dataShareId combination, is covered in GdsDBStore.validate > On Sept. 30, 2023, 1:51 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java > > Lines 834 (patched) > > <https://reviews.apache.org/r/74611/diff/2/?file=2279987#file2279987line835> > > > > Consider adding validation that each entry in dataSharesInDataset has > > datasetId specified in the parameter datasetId. Added validation. - Subhrat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74611/#review225801 ----------------------------------------------------------- On Oct. 1, 2023, 1:37 p.m., Subhrat Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74611/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2023, 1:37 p.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, and Prashant Satam. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4415 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4415 > > > Repository: ranger > > > Description > ------- > > In Dataset details page - Add datashare - user can select multiple datasets > and send request to dataset owner. We need a new POST API that can accept > request for multiple datashares. > Added API /dataset/{id}/datashare to accept List<RangerDataShareInDataset> > and return List<RangerDataShareInDataset>. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > ce4769569 > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 56b908625 > > security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java > b22208773 > > > Diff: https://reviews.apache.org/r/74611/diff/3/ > > > Testing > ------- > > Validated: > 1. Addition of multiple datashares in POST API. > 2. Tried to add duplicate request (same datashare and dataset ID), 400 is > thrown. > 3. Tried to add an existing request, with request for 2 new datashares in a > dataset. API failed for all the requests. > > > Thanks, > > Subhrat Chaudhary > >
