mneethiraj commented on code in PR #442: URL: https://github.com/apache/ranger/pull/442#discussion_r1881212308
########## agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerValidityScheduleEvaluator.java: ########## @@ -96,11 +92,37 @@ public RangerValidityScheduleEvaluator(String startTimeStr, String endTimeStr, S } } - public boolean isApplicable(long accessTime) { + public static long getAdjustedTime(long localTime, TimeZone timeZone) { + long ret = localTime; + + if (LOG.isDebugEnabled()) { Review Comment: The argument involves a `new Date(localTime)`; in such cases, use of `LOG.isDebugEnabled()` is justified to avoid any performance penalty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org