mneethiraj commented on code in PR #442:
URL: https://github.com/apache/ranger/pull/442#discussion_r1881213175


##########
agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java:
##########
@@ -73,41 +71,48 @@ public RangerDefaultPolicyResourceMatcher(boolean 
forceEnableWildcardMatch) {
         this.forceEnableWildcardMatch = forceEnableWildcardMatch;
     }
 
-    @Override
-    public void setServiceDef(RangerServiceDef serviceDef) {
-        if (isInitialized) {
-            LOG.warn("RangerDefaultPolicyResourceMatcher is already 
initialized. init() must be done again after updating serviceDef");
+    public static boolean isHierarchyValidForResources(List<RangerResourceDef> 
hierarchy, Map<String, ?> resources) {
+        if (LOG.isDebugEnabled()) {

Review Comment:
   The argument has StringUtils.join(), which can be expensive. Hence leaving 
`LOG.isDebugEnabled()` in place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to