kumaab commented on code in PR #593:
URL: https://github.com/apache/ranger/pull/593#discussion_r2166905768


##########
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java:
##########
@@ -123,6 +128,10 @@ public RangerKeyStoreProvider(Configuration conf) throws 
Throwable {
         final DaoManager   daoManager  = rangerKMSDB.getDaoManager();
         final RangerKMSMKI masterKeyProvider;
 
+        String storeType = conf.get("ranger.keystore.file.type", 
KeyStore.getDefaultType());
+        this.isFIPSEnabled = StringUtils.equalsIgnoreCase("bcfks", storeType) 
? true : false;
+        logger.info("isFIPSEnabled=" + isFIPSEnabled);

Review Comment:
   Please avoid string concatenation, please check other references as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to