vikaskr22 commented on code in PR #605:
URL: https://github.com/apache/ranger/pull/605#discussion_r2209321099
##########
kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java:
##########
@@ -49,18 +49,23 @@
public class RangerMasterKey implements RangerKMSMKI {
private static final Logger logger =
LoggerFactory.getLogger(RangerMasterKey.class);
+ public static final int PADDING_STRING_ELEM_COUNT = 7;
+
private static final String DEFAULT_MK_CIPHER = "AES";
private static final int DEFAULT_MK_KeySize = 256;
private static final int DEFAULT_SALT_SIZE = 8;
private static final String DEFAULT_SALT =
"abcdefghijklmnopqrstuvwxyz01234567890";
- private static final String DEFAULT_CRYPT_ALGO =
"PBEWithMD5AndTripleDES";
private static final int DEFAULT_ITERATION_COUNT = 1000;
private static final Properties serverConfigProperties = new
Properties();
+ private static SupportedPBECryptoAlgo defaultCryptAlgo =
SupportedPBECryptoAlgo.PBEWithMD5AndTripleDES;
+ private static SupportedPBECryptoAlgo encrCryptoAlgo =
defaultCryptAlgo;
+
public static final String DBKS_SITE_XML =
"dbks-site.xml";
private static String password = null;
- private static String DEFAULT_MD_ALGO;
+ private static String defaultMdAlgo;
+ private static boolean isFipsEnabled;
public static String MK_CIPHER;
public static Integer MK_KeySize = 0;
Review Comment:
@kumaab , It seems this PR doesn't contain the code-style changes commit (
05d4ff8ee37fb7d6712cf7fb6c473e45e3074358 ). merging this PR before code-style
changes may create many code conflicts. If we are planning to take that commit,
I would suggest to merge that first and then this PR. This feature was
developed on top of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
