pradeepagrawal8184 commented on code in PR #1107:
URL: https://github.com/apache/ranger/pull/1107#discussion_r3843423732


##########
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java:
##########
@@ -174,6 +177,7 @@ public void run() {
         LOG.debug("==> AtlasRESTTagSource.run()");
 
         while (true) {
+            StopWatch eventStopWatchRest = new StopWatch().start();

Review Comment:
   it seems updateTotalUploadsTime(timeElapsed) runs every loop iteration and 
includes the full sleep interval, not just upload work. Metric name suggests 
upload time but measures cycle time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to