pradeepagrawal8184 commented on code in PR #1107:
URL: https://github.com/apache/ranger/pull/1107#discussion_r3843432835


##########
tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java:
##########
@@ -70,6 +71,12 @@ protected void updateSink(final ServiceTags toUpload) throws 
Exception {
                 if (LOG.isDebugEnabled()) {
                     LOG.debug("Uploaded serviceTags={}", 
JsonUtils.objectToJson(uploaded));
                 }
+                if (!uploaded.getTags().isEmpty()) {
+                    RangerTagSyncMetricsSourceTags.updateTotalUploads();

Review Comment:
   TotalUploads increments only when !uploaded.getTags().isEmpty(). Uploads 
with service resources but no tags are not counted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to