pradeepagrawal8184 commented on code in PR #1171:
URL: https://github.com/apache/ranger/pull/1171#discussion_r3862744303
##########
unixauthservice/conf.dist/ranger-ugsync-default.xml:
##########
@@ -93,4 +93,12 @@
<name>ranger.usersync.dest.ranger.session.cookie.name</name>
<value>RANGERADMINSESSIONID</value>
</property>
+ <property>
+ <name>ranger.usersync.unix.auth.enabled</name>
+ <value>false</value>
+ </property>
+ <property>
+ <name>ranger.usersync.unix.backend</name>
+ <value>nss</value>
Review Comment:
what was the previous default value for this property?
##########
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java:
##########
@@ -195,13 +195,15 @@ public class UserGroupSyncConfig {
/* SSL Configs */
private static final String SSL_KEYSTORE_FILE_TYPE_PARAM =
"ranger.keystore.file.type";
private static final String SSL_TRUSTSTORE_FILE_TYPE_PARAM =
"ranger.truststore.file.type";
- private static final String SSL_KEYSTORE_PATH_PARAM =
"ranger.usersync.keystore.file";
- private static final String SSL_KEYSTORE_PATH_PASSWORD_PARAM =
"ranger.usersync.keystore.password";
+ private static final String SSL_KEYSTORE_PATH_PARAM =
"ranger.usersync.service.https.attrib.keystore.file";
Review Comment:
it seems setup.py still using "ranger.usersync.keystore.file" and
ranger-ugsync-template.xml does not have entry of
ranger.usersync.service.https.attrib.keystore.file ; am i missing something
here.
##########
unixauthservice/src/main/java/org/apache/ranger/authentication/server/RangerUserSyncStarter.java:
##########
@@ -43,8 +43,7 @@ public void init() {
static class UnixAuthenticationServiceThread extends Thread {
@Override
public void run() {
- String[] params = {"-enableUnixAuth"};
Review Comment:
address this in ranger_usersync.py file as well
##########
unixauthservice/scripts/install.properties:
##########
@@ -28,6 +28,11 @@ POLICY_MGR_URL =
# defaults to unix
SYNC_SOURCE = unix
+# Enable unix auth service, only when sync source is set to unix along with
unix backend is set to passwd.
+# Also, Unix authentication is enabled in Ranger Admin.
+# defaults to false
+ENABLE_UNIX_AUTH = false
+
Review Comment:
what will happen to upgrade case by default. probably they have to edit this
line if they want to continue with unixauth.
##########
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java:
##########
Review Comment:
Can you test this once when unix auth is disabled and usersync is running in
HA once.
##########
unixauthservice/scripts/install.properties:
##########
@@ -61,10 +66,12 @@ hadoop_conf=/etc/hadoop/conf
#
CRED_KEYSTORE_FILENAME=/etc/ranger/usersync/conf/rangerusersync.jceks
-# SSL Authentication
-AUTH_SSL_ENABLED=false
+# SSL Authentication configuration to be used when unix authentication is
enabled.
+AUTH_SSL_ENABLED=true
Review Comment:
i think we should this also as false when ENABLE_UNIX_AUTH is false by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
