fimugdha commented on code in PR #1171:
URL: https://github.com/apache/ranger/pull/1171#discussion_r3895361320
##########
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java:
##########
@@ -195,13 +195,15 @@ public class UserGroupSyncConfig {
/* SSL Configs */
private static final String SSL_KEYSTORE_FILE_TYPE_PARAM =
"ranger.keystore.file.type";
private static final String SSL_TRUSTSTORE_FILE_TYPE_PARAM =
"ranger.truststore.file.type";
- private static final String SSL_KEYSTORE_PATH_PARAM =
"ranger.usersync.keystore.file";
- private static final String SSL_KEYSTORE_PATH_PASSWORD_PARAM =
"ranger.usersync.keystore.password";
+ private static final String SSL_KEYSTORE_PATH_PARAM =
"ranger.usersync.service.https.attrib.keystore.file";
Review Comment:
@pradeepagrawal8184, the "ranger.usersync.keystore.file" will be used in
case of unix authentication is enabled.
The "ranger.usersync.service.https.attrib.keystore.file" new config changes
where not added as a part of this PR -
https://github.com/apache/ranger/pull/1103/changes#diff-20795b8427231f8ec96f91b20a1bae2804a6f23327f44fe6156ee8677e9109f5.
Currently SSL enable is not used on default docker setup.
Do you think I need to handle the change of adding this new config into the
usersync `install.properties` and in `ranger-ugsync-template.xml` files in this
pull-request ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
