maheshbandal15 commented on code in PR #1231:
URL: https://github.com/apache/ranger/pull/1231#discussion_r4148500091
##########
audit-server/audit-dispatcher/dispatcher-common/src/main/java/org/apache/ranger/audit/dispatcher/kafka/AuditDispatcherBase.java:
##########
@@ -102,10 +121,13 @@ public AuditDispatcherBase(Properties props, String
propPrefix, String dispatche
topicName = MiscUtil.getStringProperty(props, propPrefix + "." +
AuditServerConstants.PROP_TOPIC_NAME, AuditServerConstants.DEFAULT_TOPIC);
}
- AuditDispatcherBase(String dispatcherGroupId, KafkaConsumer<String,
String> dispatcher, String topicName) {
- this.dispatcherGroupId = dispatcherGroupId;
- this.dispatcher = dispatcher;
- this.topicName = topicName;
+ AuditDispatcherBase(String dispatcherGroupId, KafkaConsumer<String,
String> dispatcher, String topicName, long authzRetryDelayMs, long
authnRetryDelayMs, long pollErrorRetryDelayMs) {
+ this.dispatcherGroupId = dispatcherGroupId;
+ this.dispatcher = dispatcher;
+ this.topicName = topicName;
+ this.authzRetryDelayMs = authzRetryDelayMs;
+ this.authnRetryDelayMs = authnRetryDelayMs;
+ this.pollErrorRetryDelayMs = pollErrorRetryDelayMs;
}
Review Comment:
@rameeshm AuditDispatcherBase.java now exposes a 6-arg constructor but
[AuditOpenSearchDispatcher.java#L56](https://github.com/apache/ranger/blob/63e5bd7040954455f89c5f6f4615a92d18093510/audit-server/audit-dispatcher/dispatcher-opensearch/src/main/java/org/apache/ranger/audit/dispatcher/kafka/AuditOpenSearchDispatcher.java#L56)
still calls `super(dispatcherGroupId, dispatcher, topicName);` which results
in compilation failure.
run `cd audit-server && mvn clean install`
>
ranger/audit-server/audit-dispatcher/dispatcher-opensearch/src/main/java/org/apache/ranger/audit/dispatcher/kafka/AuditOpenSearchDispatcher.java:[56,14]
error: incompatible types: String cannot be converted to Properties
Please consider restoring 3-arg constructor or update
AuditOpenSearchDispatcher’s constructor to pass the same delay values as the
base tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
