rameeshm commented on code in PR #1231:
URL: https://github.com/apache/ranger/pull/1231#discussion_r4151137560
##########
audit-server/audit-dispatcher/dispatcher-common/src/main/java/org/apache/ranger/audit/dispatcher/kafka/AuditDispatcherBase.java:
##########
@@ -102,10 +121,13 @@ public AuditDispatcherBase(Properties props, String
propPrefix, String dispatche
topicName = MiscUtil.getStringProperty(props, propPrefix + "." +
AuditServerConstants.PROP_TOPIC_NAME, AuditServerConstants.DEFAULT_TOPIC);
}
- AuditDispatcherBase(String dispatcherGroupId, KafkaConsumer<String,
String> dispatcher, String topicName) {
- this.dispatcherGroupId = dispatcherGroupId;
- this.dispatcher = dispatcher;
- this.topicName = topicName;
+ AuditDispatcherBase(String dispatcherGroupId, KafkaConsumer<String,
String> dispatcher, String topicName, long authzRetryDelayMs, long
authnRetryDelayMs, long pollErrorRetryDelayMs) {
+ this.dispatcherGroupId = dispatcherGroupId;
+ this.dispatcher = dispatcher;
+ this.topicName = topicName;
+ this.authzRetryDelayMs = authzRetryDelayMs;
+ this.authnRetryDelayMs = authnRetryDelayMs;
+ this.pollErrorRetryDelayMs = pollErrorRetryDelayMs;
}
Review Comment:
@maheshbandal15 Thanks for the review. I have update to have only 3 args and
pass the values for testing and won't have any separate constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
