vyommani commented on PR #1267: URL: https://github.com/apache/ranger/pull/1267#issuecomment-5978222412
> Thank you for the detailed feedback — you’re right. I’ve updated the patch to address the points you raised, added a test with real GraalJS, and pushed the changes. Please let me know if I missed anything. The shared Engine, a new Context.Builder per getScriptEngine(), and closing the GraalJSBindings after each evaluation look right. The GraalJS test covers a closed bindings context, a failed script, and a later eval on the same engine. The shared engine should stay open. Two changes before this is ready: 1. close() is now a public method on RangerRequestScriptEvaluator, and GraalScriptEngineCreator.buildHostAccess() allow-lists every public instance method on that class. The evaluator is bound as ctx, so a script can call ctx.close() and close the context while it is still running. Skip close when building that HostAccess allow-list. 2. there are some check-style issues in test please build locally and fix before updating the pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
