vyommani commented on PR #1327: URL: https://github.com/apache/ranger/pull/1327#issuecomment-6357551923
> @vyommani - instead of introducing a new table, `x_constraint_def`, how about persisting entire service-def json in a new column `x_service_def.def_text` - similar to use of `x_policy.policy_text` and `x_service_resource.service_resource_elements_text`? This will make loading and persisting of service-def more efficient, similar to the improvement for policies in [RANGER-2203](https://issues.apache.org/jira/browse/RANGER-2203). Madhan, that works, and I’ll update this PR to match. I’ll drop x_constraint_def and store the service def in a new x_service_def.def_text column, the same way x_policy.policy_text works. Create and update will write the full service-def JSON there. Get will read that column when it’s set, and use the current child-table load when it’s null. A Java patch will fill def_text for existing service defs. The current child tables stay, because policy and zone ref updates look up resource, access-type and condition rows by id. constraintDefs will live only in def_text, so the ref for constraint policies in RANGER-5852 will use the constraint name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
