mneethiraj commented on code in PR #1327:
URL: https://github.com/apache/ranger/pull/1327#discussion_r4360320325
##########
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java:
##########
@@ -698,6 +700,8 @@ public RangerServiceDef createServiceDef(RangerServiceDef
serviceDef) throws Exc
}
}
+ updateServiceDefText(createdSvcDef, constraintDefs);
Review Comment:
Ok. I meant to say `createdServiceDef` (which is initialized in the
following line), instead of `createdSvcDef`.
Anyway, the goal is to follow the same approach used to save/update
RangerPolicy - in ServiceDBStore.createPolicy() and
RangerPolicyServiceBase.mapViewToEntityBean(). Note that
RangerPolicyServiceBase.mapEntityToViewBean() must also be updated to read
service-def from XXServiceDef.defText field, if its not empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
