----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55365/#review161034 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/authorization/hadoop/constants/RangerHadoopConstants.java (line 82) <https://reviews.apache.org/r/55365/#comment232304> property name specified here is "." - which needs to be updated, to something like "ranger.plugin.hdfs.filename.extension.separator". Also, consider moving this to RangerHdfsAuthorizer.java - as this is specific to HDFS plugin. - Madhan Neethiraj On Jan. 10, 2017, 2:01 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55365/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 2:01 a.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-1302 > https://issues.apache.org/jira/browse/RANGER-1302 > > > Repository: ranger > > > Description > ------- > > Populate RangerAccessRequest context with "FILENAME" and if possible with > "BASE_FILENAME" before authorization request to Ranger. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/constants/RangerHadoopConstants.java > 83f720a > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java > 4d6cb0d > > hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java > 726494a > hdfs-agent/src/test/resources/hdfs-policies.json eb61796 > > Diff: https://reviews.apache.org/r/55365/diff/ > > > Testing > ------- > > Enhanced hdfs-plugin unit tests, and ensured that they pass. > > > Thanks, > > Abhay Kulkarni > >
