----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55365/#review161092 -----------------------------------------------------------
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java (line 536) <https://reviews.apache.org/r/55365/#comment232330> it will be safer to handle the case "inode == null" here. hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java (line 398) <https://reviews.apache.org/r/55365/#comment232329> Consider adding tests to ensure that the policy does not apply to the following files: - /tmp/tmpdir5/data-file.csv - /tmp/tmpdir5/t/data-file.txt - /tmp/tmpdir4/t/abc - Madhan Neethiraj On Jan. 10, 2017, 7:42 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55365/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 7:42 a.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-1302 > https://issues.apache.org/jira/browse/RANGER-1302 > > > Repository: ranger > > > Description > ------- > > Populate RangerAccessRequest context with "FILENAME" and if possible with > "BASE_FILENAME" before authorization request to Ranger. > > > Diffs > ----- > > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java > 4d6cb0d > > hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java > 726494a > hdfs-agent/src/test/resources/hdfs-policies.json eb61796 > > Diff: https://reviews.apache.org/r/55365/diff/ > > > Testing > ------- > > Enhanced hdfs-plugin unit tests, and ensured that they pass. > > > Thanks, > > Abhay Kulkarni > >
