This is my bad. Apologies for this. I’ve filed RIPPLE-95 and submitted a PR which fixes this: https://github.com/apache/incubator-ripple/pull/70 <https://github.com/apache/incubator-ripple/pull/70>
It just rolls back the validation to previous no-validation state. I’ll work on a proper validation (and tests) and submit it shortly. Tim, Brent, if you could review and merge the change, it’d be great. Again, I’m sorry about the overhead this is causing. -- // kai > On Jul 30, 2015, at 12:54, Brent Lintner <[email protected]> wrote: > > Kudos on bumping us, Tim! :-D > > -1 (perhaps?) > > Steps I took: > > * Verified `configure` script runs successfully > * Build test (jake build) > * Build with minimization test (jake deploy) > * Ran tests (jake test & jake btest) > * Quick CLI run and sanity check > * jake rat > > BUT: > > ./bin/ripple emulate --remote http://google.com --port 4000 > > Is broken for me. I get: > > ~/Downloads/ripple-emulator-0.9.31-incubating$ ./bin/ripple emulate --port > 2000 --remote http://google.com > Options not understood: emulate --port 2000 --remote http://google.com > > The lib/cli/emulate.js module seems to validate things oddly: > > https://github.com/apache/incubator-ripple/blob/master/lib/cli/emulate.js#L38-L51 > > I am not sure, but it looks like that is the culprit. > > On Wed, 29 Jul 2015 at 10:25 Raymond Camden <[email protected]> wrote: > >> Query - when released - where will it be announced/documented? >> >> On Wed, Jul 29, 2015 at 9:23 AM, Sergey Grebnov (Akvelon) >> <[email protected]> wrote: >>> I vote +1: >>> >>> * Verified installation from npm (ripple-emulator@rc) >>> * Reviewed package content and CHANGELOG >>> * Manually verified core 'ripple emulate' functionality for Cordova app >>> * Verified accelerometer plugin and simulation UI works correct >>> >>> Thx! >>> Sergey Grebnov >>> >>> -----Original Message----- >>> From: Tim Barham [mailto:[email protected]] >>> Sent: Tuesday, July 28, 2015 1:34 AM >>> To: [email protected] >>> Subject: Re: [VOTE] Ripple release 0.9.31 >>> >>> Bump! >>> >>> Come one guys - this is an easy one (especially compared to last time), >> and it would be nice to get those bug fixes out. >>> >>> Thanks! >>> >>> Tim >>> >>> ________________________________________ >>> From: Tim Barham <[email protected]> >>> Sent: Thursday, July 23, 2015 6:02 PM >>> To: [email protected] >>> Subject: RE: [VOTE] Ripple release 0.9.31 >>> >>> Slight correction to my verification steps: "Manually verified there >> were no new source files that need license headers..." should read: >> "Manually verified the single new source file had an Apache license >> header..." >>> >>> -----Original Message----- >>> From: Tim Barham [mailto:[email protected]] >>> Sent: Thursday, July 23, 2015 5:51 PM >>> To: [email protected] >>> Subject: [VOTE] Ripple release 0.9.31 >>> >>> Now that we have 0.9.30 out the door, we need to do another release to >> take some important bug fixes. >>> >>> Please review and vote on the release of Ripple 0.9.31. >>> >>> The package you are voting on is available for review at >> https://dist.apache.org/repos/dist/dev/incubator/ripple/. It was >> published from its corresponding git tag: >>> >>> incubator-ripple: 0.9.31 (68f124a84a) >>> >>> While we need three +1 *binding* votes (which for an Apache Incubator >> project like Ripple means Apache IPMC members), active Ripple contributors >> and committers/PPMC members are still encouraged to review the release and >> vote. Before voting +1, please refer to and verify compliance with the >> checklist at >> http://incubator.apache.org/guides/releasemanagement.html#check-list >> (however, we only need to consider changes since the previous release). >>> >>> If you do vote +1, please include the steps you took in order to be >> confident the release meets requirements. >>> >>> Upon a successful vote, I will upload the archive to >> dist/release/incubator/ripple and publish it to NPM. >>> >>> I vote +1: >>> * Verified license headers with Apache RAT (using 'jake rat'). >>> * Manually verified there were no new source files that need license >> headers, nor new third party dependencies that needed to have license >> information included in the LICENSE file. >>> * Verified the build works and all tests pass. >>> * Manually tested all changes that have been made since the last release. >>> >>> Thanks! >>> >>> Tim >>> >> >> >> >> -- >> =========================================================================== >> Raymond Camden, Developer Advocate for MobileFirst at IBM >> >> Email : [email protected] >> Blog : www.raymondcamden.com >> Twitter: raymondcamden >>
