I've noticed some new classes in the net.jini namespace, we need to move them to org.apache.river prior to release please, unless there is a good reason they should be there.

Regards,

Peter.

Peter Firmstone wrote:
Simon IJskes - QCG wrote:
On 28-10-12 15:47, Simon IJskes - QCG wrote:
On 28-10-12 15:45, Simon IJskes - QCG wrote:
On 28-10-12 15:43, Tom Hobbs wrote:
Can someone refresh my memory, please?  I recall a few months ago we
were
talking about gearing up for a release.  Is there any reason why we
can't
cut one now-ish?

none. go for it!

Although, what do we do with the failing tests since the URL->URI commits?





I recall recently some tests were failing because of spaces in path names, but that's what I'd expect; spaces are used as codebase delimiters, so failure is correct because the path is incorrectly formatted.

When I was developing URI changes, all tests passed when path names were correctly formatted, in fact it solved so many issues that the Windows platform can now be supported without cigwin.

If we can find a reason URI code is not standards compliant, then lets fix it, but it's up to users for format their paths correctly. I've provided a utility class for that purpose.

I do have a suggestion prior to release though, that all new code in org.apache.river be separated into org.apache.river.api or org.apache.river.impl.

Cheers,

Peter.



Reply via email to