In order to gain some time to discuss this first i will vote -1.
First, we decided to NOT remove velocity builder.
Second, no need to remove the jars as specified in your own comments on
RIVER-432.
Pulling in external jars at compile time, shall we start here?
They are already in the svn. They are already in the build scripts. What
does this patch fix? No legal problems?
Pulling external jars at compile time also makes it more difficult to
certify the software. In order to certify the software you need to
establish baseline that will be garanteed the same, even if you pull it
from the archive 10 years later.
It is not a high level project that builds on several frameworks. It is
a lowlevel system library. The stuff below the stack is minimal. The
number of jars we use is limited. Why bother?
Gr. Simon
On 02-01-14 18:22, Greg Trasuk wrote:
Hello all:
Please have a look at the patch mentioned below and cast a vote on it.
The main idea is to remove the dependency jar files from the source
distribution. As a side effect of using Ivy, it becomes reasonable to remove
them from the svn archive as well. Also, the Velocity dependency was there to
support the VelocityConfigurationBuilder. We had discussed removing that
component, so rather than move that dependency to Ivy, I’ve removed
VelocityConfigurationBuilder.
It’s arguable whether the VelocityConfigurationBuider was part of the official
Jini API (I see it as a utility, not API), so I don’t think this commit
actually requires a vote. However, it does seem like a significant change to
the build process that ought to be reviewed. So I propose to treat this as a
“lazy consensus” vote, and will commit the change to the 2.2 branch if there
are no objections in 72 hours (i.e. 1730UTC 20140105).
At the same time, based on discussions over on gene...@incubator.apache.org,
I’ll withdraw my assertion that we can’t have jars in svn. Those interested
may want to check out the thread at
http://mail-archives.apache.org/mod_mbox/incubator-general/201312.mbox/%3C01B04CC4-95B8-4A39-BC16-04BAA4269B65%40stratuscom.com%3E
Cheers,
Greg.
On Jan 2, 2014, at 12:05 PM, Greg Trasuk (JIRA) <j...@apache.org> wrote:
[
https://issues.apache.org/jira/browse/RIVER-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Trasuk updated RIVER-432:
------------------------------
Attachment: river-2_2_remove_jars.diff
The attached patch for the 2.2 branch does the following:
- removes the 'asm' directory and 'tests/lib' directories which currently
contain the asm library, mockito, and junit jars.
- Modifies 'build.xml', 'common.xml', and adds 'ivy.xml' so that the Apache Ivy
ant plugin is downloaded at build time, and then used to retrieve the libraries
mentioned above from Maven Central. This removes the need to have the jar
files in svn.
- Removes (as per discussion
http://mail-archives.apache.org/mod_mbox/river-dev/201211.mbox/%3C509B99E3.6080800%40qcg.nl%3E)
the VelocityConfigBuilder, and associated Velocity jars. Note that the
'extras' folder is not present in the 2.2 branch, so Sim's last comments in the
thread do not apply.
Jar files in svn and src distributions
--------------------------------------
Key: RIVER-432
URL: https://issues.apache.org/jira/browse/RIVER-432
Project: River
Issue Type: Bug
Reporter: Greg Trasuk
Attachments: river-2_2_remove_jars.diff
Recent traffic on the incubator lists has pointed out that including jar files
for dependencies in the subversion repository and the source distributions is
against Apache policy.
In River, the following libraries appear in the Subversion repository and the
source distributions (these are from trunk, a smaller set appear in the 2.2
branch):
animal-sniffer
asm
bouncy-castle
dnsjava
high-scale-lib
rc-libs
velocity
They all have to go. What are we using them for? As I understand it, we were
going to remove the VelocityConfigurationBuilder, so that's not a problem.
Some of the others are available from Maven Central, so we can get them at
build time using Ivy or another build tool. Which ones are actually required?
And where did they come from?
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
--
QCG, Software voor het MKB, 071-5890970, http://www.qcg.nl
Quality Consultancy Group b.v., Leiderdorp, Kvk Den Haag: 28088397
