Top job Reedy, gold standard, these examples show not only how River is
relevant now, but in my eyes also demonstrate best practise, with Maven
packaging conventions and Groovy config.
Quick suggestion for GreeterService; make the service field volatile,
this will ensure that all state in the Service object is published
during the start call, guaranteeing that a thread calling destroy
(different to the one that calls start), will see not only the reference
to service, but its most up to date state at that time as well.
Nice usage of the builder pattern too with descriptive methods.
+1 on removing the old examples.
Regards,
Peter.
On 16/09/2015 5:36 AM, Dennis Reedy wrote:
Greg,
Agree 100% with the old examples. BTW, I am working on an example (extends on
what you have already created) that uses River 3.0, Gradle and the Groovy
configuration approach. I thought it might be a good idea to show how one could
use Gradle in addition to Maven. The project includes integrated JUnit testing
as well as support for starting reggie and the browser from the Gradle project
(no need for external scripts).
For now, I’ve put it up on GitHub
(https://github.com/dreedyman/apache-river-example), you’ll need to build and
install River 3.0 for it to work. It still needs work, you’ll see your
webapp-client there as well.
Regards
Dennis
On Sep 15, 2015, at 227PM, Greg Trasuk<tras...@stratuscom.com> wrote:
I notice that Dennis just added a pom for the browser to the “River 3.0”/
qa-refactor-namespace branch.
The examples, including the browser, are pretty confusing and out-of-date in
the main JTSK distribution. I would suggest removing them, since we have a
separate examples project. We’d have to do another version of the examples
home build that calls out the River 3.0 jars.
In other words, let’s improve the newbie experience by pointing people to a
better set of examples that doesn’t require new developers to build the entire
JTSK. I suggest simply deleting the examples folder from the starter kit.
Also, is somebody going to merge back to trunk at some point?
Cheers,
Greg Trasuk
