On Sun, Jul 5, 2020 at 8:07 AM Peter Firmstone <peter.firmst...@zeus.net.au> wrote: > > Hi Phil, > > I've been going through your patch, you've got a lot of work done in a > short time. :) > > I've just committed your changes. > > I'll have a look at the circular dependencies and see what I can do in > the coming week.
Sounds good. I may also be able to free up some time to work on that some more. I thought I'd try slowly moving classes back to their original locations, from where I moved them to river-lib, and try to isolate the absolute smallest number of classes that are circularly dependent. Although it may turn out that you, or somebody else who knows this code better, may be able to just jump in and quickly work it all out. Hopefully that will be the case, and will moot the need for the exercise described above. :-) In any case, all of this is good for me as far as getting familiar with the River code in general. Phil