MatrixHB commented on PR #4115:
URL: https://github.com/apache/rocketmq/pull/4115#issuecomment-1088602648
@dugenkui03
I‘ve just found that in the `5.0.0-beta` branch provided by rocketmq-team,
there is already `queryConsumeTimeSpanConcurrent` method to solve my problem.
But the `queryConsumeTimeSpanConcurrent` added in 5.0.0-beta has some
problems:
1、Using countDownLatch, `spanSet.addAll()` executed in each thread is not
thread-safe, because spanSet is not copy-on-write
2、IMO, add concurrent method separately makes DefaultMQAdminExtImpl
method-expansion, not so elegant.
3、The thread pool parameter setting can be optimized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
