lizhiboo commented on code in PR #4115:
URL: https://github.com/apache/rocketmq/pull/4115#discussion_r844992872


##########
tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java:
##########
@@ -147,6 +157,8 @@ public void start() throws MQClientException {
 
                 mqClientInstance.start();
 
+                executors = Executors.newCachedThreadPool(new 
ThreadFactoryImpl("MQAdminThread_"));

Review Comment:
   IMO,it's better to specify pool core size, max size, length of waiting list 
and reject conduct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to