Github user zhouxinyu commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94042046
  
    --- Diff: 
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
    @@ -39,11 +39,15 @@
     
         private final int mappedFileSize;
     
    -    private final CopyOnWriteArrayList<MappedFile> mappedFiles = new 
CopyOnWriteArrayList<MappedFile>();
    +    private final CopyOnWriteArrayList<MappedFile> mappedFiles = new 
CopyOnWriteArrayList<>();
     
         private final AllocateMappedFileService allocateMappedFileService;
     
    -    private long flushedWhere = 0;
    --- End diff --
    
    Consider the abuse of `offset` in rocketmq-store, so we use `flushedWhere` 
and `committedWhere`.
    
    `flushedWhere` means the offset of all mappedFile, while `offset` means the 
offset of one mappedFile in general. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to