Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/20 @zhouxinyu I made changes according to your comments, and added more tests. In {{CommitLog.FlushRealTimeService#run()}}, we will try to flush as long as the data is available or {{MAX_FLUSH_COMMIT_NUM}} is not reached, logging when flushing fails. It is almost same as before (checking the return value of {{flush()}}) but checking if looks neat to me. What do you think?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---